git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] fix memory leak in git-am

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 27, 2017, 05:41 UTC
Message-ID
<xmqqd1byo196.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170427032503.rgz3bnctnxdn3hin@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 14 quoted lines
> This was noticed by Coverity. The leak isn't new, but I think was
> "re-found" by Coverity because some nearby code did an unrelated
> s/sha1/oid/ change, throwing off its heuristics.
>
> I also checked whether this was in Dscho's big pack of Coverity fixups
> from earlier today, and it's not.
>
> The first one is the actual fix. The second one is pure cleanup, but I
> think worth doing. The final one is arguably just churn, and maybe
> people even like the end result less. I'm OK to drop it.
>
>   [1/3]: am: fix commit buffer leak in get_commit_info()
>   [2/3]: am: simplify allocations in get_commit_info()
>   [3/3]: am: shorten ident_split variable name in get_commit_info()
All looked sensible.  Thanks.
Previous: Jeff King
Message 5 of 5 in “fix memory leak in git-am”
  1. 0/3 fix memory leak in git-amJeff King, Apr 27, 2017
  2. 1/3 am: fix commit buffer leak in get_commit_info()Jeff King, Apr 27, 2017
  3. 2/3 am: simplify allocations in get_commit_info()Jeff King, Apr 27, 2017
  4. 3/3 am: shorten ident_split variable name in get_commit_info()Jeff King, Apr 27, 2017
  5. Junio C HamanoApr 27, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.