[PATCH 1/3] am: fix commit buffer leak in get_commit_info()
- From
Jeff King <peff@peff.net>
- Date
- Apr 27, 2017, 03:25 UTC
- Message-ID
- <20170427032555.imjr5to4uys2cz4k@sigill.intra.peff.net>
- In-Reply-To
- <20170427032503.rgz3bnctnxdn3hin@sigill.intra.peff.net>
Calling logmsg_reencode() may allocate a buffer for the commit message (because we need to load it from disk, or because it needs re-encoded). We must "unuse" it afterwards to free it.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/am.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/builtin/am.c b/builtin/am.c index 805f56cec..baab951ed 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -1421,6 +1421,7 @@ static void get_commit_info(struct am_state *state, struct commit *commit) die(_("unable to parse commit %s"), oid_to_hex(&commit->object.oid)); state->msg = xstrdup(msg + 2); state->msg_len = strlen(state->msg); + unuse_commit_buffer(commit, buffer); } /**
-- 2.13.0.rc0.465.ga1e654229