Re: [PATCH] t0000: check whether the shell supports the "local" keyword

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2017, 01:15 UTC
Message-ID: <xmqqd159e6go.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+P7+xoCKTaG9kV2T9YUHvagHVzD6v7A=neLzF3Qj1q8Fi0u-w@mail.gmail.com>

Jacob Keller <jacob.keller@gmail.com> writes:

Show 11 quoted lines

> I don't think you're missing anything. I think the idea here is: "do
> any users who actively run the test suite care if we start using
> local". I don't think the goal is to allow use of local in non-test
> suite code. At least, that's not how I interpreted it.
>
> Thus it's fine to be only as part of a test and see if anyone
> complains, since the only people affected would be those which
> actually run the test suite...
>
> Changing our requirement for regular shell scripts we ship seems a lot
> trickier to gauge.

Yup, that matches my expectations for what we would gain out of this change.