Re: [PATCH] t0000: check whether the shell supports the "local" keyword

From: Jeff King <peff@peff.net>
Date: Oct 30, 2017, 17:39 UTC
Message-ID: <20171030173941.bye4vyi3jmkzxfr5@sigill.intra.peff.net>
In-Reply-To: <6ecab31e7ed05f5e79ecd454b133a2bfa6ac9ab7.1509005669.git.mhagger@alum.mit.edu>

On Thu, Oct 26, 2017 at 10:18:53AM +0200, Michael Haggerty wrote:

Show 8 quoted lines

> Add a test balloon to see if we get complaints from anybody who is
> using a shell that doesn't support the "local" keyword. If so, this
> test can be reverted. If not, we might want to consider using "local"
> in shell code throughout the git code base.
> 
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
> This has been discussed on the mailing list [1,2].

Thanks for following up, this looks nice and thorough to me.

-Peff