Re: [PATCH] Makefile: remove the NO_R_TO_GCC_LINKER flag

From: Junio C Hamano <gitster@pobox.com>
Date: May 16, 2019, 23:21 UTC
Message-ID: <xmqqd0ki3s0q.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190516222525.GC11784@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Far be it from me to care about AIX, but it seems like this is ripe for
> regressions, because we don't know which platforms were relying on "-R"
> instead of "-Wl,-rpath", and now everybody will be using the latter by
> default.

I do not have a stake in AIX, either, but I had the same reaction.

Those who found having to give NO_R_TO_GCC_LINKER=NoThanks annoying could have passed CC_LD_DYNPATH=-Wl,-rpath instead, but that is not much shorter or sweeter X-<; with this change, they do not have to do anything, but those who are broken can pass CC_LD_DYNPATH=-R to unbreak it. So it may not be the end of the world, but this move certainly smells like robbing non-GCC users to pay GCC users to me.