git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] connected: always use partial clone optimization

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 30, 2020, 05:12 UTC
Message-ID
<xmqqd08ua0jo.fsf@gitster.c.googlers.com>
In-Reply-To
<20200330033247.27880-1-jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 8 quoted lines
>> Sounds good.  Jonathan?  I've squashed Josh'es Reviewed-by, but I
>> will refrain from merging it to 'next' just yet to see if you too
>> like the proposed code structure.
>
> I think that this is a local enough concern that going either way won't
> paint us into a corner, so if what's in
> jt/connectivity-check-optim-in-partial-clone is OK, I prefer using that
> to reduce churn.

If you do not think their improvement is not much of improvement, then please say so. On the other hand, if you also believe that the resulting code is better, adopting the improvement (in other words, help from other people) and get a better version of the code queued before it hits 'next' is not a "churn". Leaving a chance to make the code into a shape that you think better is a waste and risking the chance to forget improving it with a follow-up patch.

Thanks.
Previous: Jonathan TanNext: Jonathan Tan
Message 8 of 11 in “connected: always use partial clone optimization”
  1. connected: always use partial clone optimizationJonathan Tan, Mar 20, 2020
  2. Junio C HamanoMar 20, 2020
  3. Josh SteadmonMar 26, 2020
  4. Emily ShafferMar 26, 2020
  5. Josh SteadmonMar 26, 2020
  6. Junio C HamanoMar 29, 2020
  7. Jonathan TanMar 30, 2020
  8. Junio C HamanoMar 30, 2020
  9. Jonathan TanMar 30, 2020
  10. Junio C HamanoMar 30, 2020
  11. Jeff KingMar 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.