Re: [PATCH] osxkeychain: restrict queries to requests with a valid host
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 21, 2020, 01:44 UTC
- Message-ID
- <xmqqd081pq79.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CAPUEspiBqCGTOfEESAqY=JR5jHhARSAODjsg5rGLxWEqzFH0zw@mail.gmail.com>
Carlo Arenas <carenas@gmail.com> writes:
Show 9 quoted lines
> On Mon, Apr 20, 2020 at 4:09 PM Junio C Hamano <gitster@pobox.com> wrote: >> >> Just to clarify, you do not need this patch to "fix" it, as long as >> you are running up-to-date Git, right? In other words, this is more >> like a belt-and-suspender protection, isn't it? > > the fixes in master do most of the work, but the way the underlying > macOS function > used works, will still randomly select a credential for cases where host=""
That is like saying "most of the work but as a protection it does not work at all and still allows a random stuff to be chosen", no?