Re: [PATCH] osxkeychain: restrict queries to requests with a valid host
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Apr 20, 2020, 23:20 UTC
- Message-ID
- <CAPUEspiBqCGTOfEESAqY=JR5jHhARSAODjsg5rGLxWEqzFH0zw@mail.gmail.com>
- In-Reply-To
- <xmqqa735rbyh.fsf@gitster.c.googlers.com>
On Mon, Apr 20, 2020 at 4:09 PM Junio C Hamano <gitster@pobox.com> wrote:
> > Just to clarify, you do not need this patch to "fix" it, as long as > you are running up-to-date Git, right? In other words, this is more > like a belt-and-suspender protection, isn't it?
the fixes in master do most of the work, but the way the underlying macOS function used works, will still randomly select a credential for cases where host=""
Carlo