Re: [PATCH v13 1/3] grep: refactor next_match() and match_one_pattern() for external use

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 15, 2021, 19:49 UTC
Message-ID: <xmqqczo65ar1.fsf@gitster.g>
In-Reply-To: <xmqqk0ie5bpx.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> Hamza Mahfooz <someguy@effective-light.com> writes:
>
>> On Fri, Oct 15 2021 at 11:05:24 AM -0700, Junio C Hamano
>> <gitster@pobox.com> wrote:
>>> Makes readers curious what happend in v11 and later...
>>
>> It was my understanding that no comment means nothing changed since
>> then, or is something to the effect of "no changes" preferable?
>
> Usually people do not want to spam the list with a multi-patch
> series when they have nothing new to show, unless there are other
> reasons to do so, like "there is no change, but I am sending it
> again because nobody seemed to have time reviewing the series the
> last time", in which case that would make a good explanation to put
> there.

Ah, I thought I was responding to a cover letter. OK, so you were saying that there was no change in 1/3, but other steps may be different.

In that case, that makes sense (even though it is more helpful to just say "v13: same as v12" or something).

Thanks.