Re: [PATCH] grep: avoid setting UTF mode when not needed

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 16, 2021, 18:48 UTC
Message-ID: <xmqq35nwaqd7.fsf@gitster.g>
In-Reply-To: <211116.86tugcp8mg.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 19 quoted lines

> In the context of this being a pretty urgent post-release fix (but I
> don't know if Junio would consider a point-release, so perhaphs it's
> not) I'd be OK with either of:
>
>  A. Let's back out this new log grep color thing entirely while we
>     reconsider this. The gitster/hm/paint-hits-in-log-grep topic
>     currently reverts cleanly.
>
>  B. Don't break the new log grep color thing, and also fix the 'grepping
>     binary' regression (which is much more important than having A)
>
> But let's not go for some in-between where we break the new feature to
> the point of it being worse than the state of not having it at all in
> v2.33.0.
>
> I.e. without the that log grep color feature we wouldn't screw up the
> display of non-ASCII characters in log output (yay), in v2.34.0 we
> don't, but also color the match (yay), but we broke grepping binary
> *files* (boo!).

Sorry, but with too many new patches on the list that are not urgent, while we wanted to see us work solely on post-release regression fixes, I do not seem to be able to locate the reports of this "breakage" and the other binary-file breakage.

But in any case, yes, since the 2.33.0 cycle was run deliberately loosely to take undercooked topics to 'next' without much reviews (no, "I looked at some part and they looked OK" is not a review), and because any topic in 'next', by default, graduates to 'master' solely on time basis, I am fully expecting that we'd have to issue 2.33.1 (and possibly .2) during the first two or three weeks of this cycle. So let's make sure we fix any iffy ones.

Downthread Carlo seem to agree with you that it would be better to revert the paint-hits-in-log-grep topic wholesale; I have not yet formed an opinion, as I haven't seen the breakage reports as I said.

As I will be offline most of the day and perhaps tomorrow, nothing may happen in the meantime on my end, but hopefully we'll see a reviewed and ready-to-be-applied patchset that people are happy with by the time I look at the list again ;-)?

Thanks.