Re: [PATCH v2 9/9] doc: git-init: clarify file modes in octal.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 28, 2021, 17:25 UTC
- Message-ID
- <xmqqcznprrik.fsf@gitster.g>
- In-Reply-To
- <xmqqilxhrrva.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> How about calling it <perm> (or <perm-bits>)?
I think it is better to queue your original as-is, as a part of the topic whose theme is to correct the formatting and phrasing without changing the spirit of the existing text.
Fixing the "umask confusion" should be left to a separate patch on top.
----- >8 --------- >8 --------- >8 --------- >8 ----- Subject: init doc: --shared=0xxx does not give umask but perm bits
The description that 0640 makes sure that the group members can read the repository is correct, but calling that octal number a <umask> is wrong. Let's call it <perm>, as the value is used to set the permission bits.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- Documentation/git-init.txt | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git c/Documentation/git-init.txt w/Documentation/git-init.txt index af0d2ee182..42268ada22 100644 --- c/Documentation/git-init.txt +++ w/Documentation/git-init.txt @@ -79,7 +79,7 @@ repository. If not specified, fall back to the default name (currently `master`, but this is subject to change in the future; the name can be customized via the `init.defaultBranch` configuration variable). ---shared[=(false|true|umask|group|all|world|everybody|<umask>)]:: +--shared[=(false|true|umask|group|all|world|everybody|<perm>)]:: Specify that the Git repository is to be shared amongst several users. This allows users belonging to the same group to push into that @@ -110,15 +110,16 @@ the repository permissions. Same as 'group', but make the repository readable by all users. -'<umask>':: +'<perm>':: -'<umask>' is an 3-digit octal number prefixed with `0` and each file -will have mode '<umask>'. '<umask>' will override users' umask(2) +'<perm>' is an 3-digit octal number prefixed with `0` and each file +will have mode '<perm>'. '<perm>' will override users' umask(2) value (and not only loosen permissions as 'group' and 'all' does). '0640' will create a repository which is group-readable, but not group-writable or accessible to others. '0660' will create a repo that is readable and writable to the current user and group, but -inaccessible to others. +inaccessible to others (directories and executable files get their +`x` bit from the `r` bit for corresponding classes of uses). -- By default, the configuration flag `receive.denyNonFastForwards` is enabled