Re: [PATCH v2 2/9] doc: split placeholders as individual tokens

From: Martin Ågren <martin.agren@gmail.com>
Date: Oct 28, 2021, 18:45 UTC
Message-ID: <CAN0heSqFNULMRGCHGAWfSj6cQ_N2-OoGm3KTc3Kzy=MwzJQWxw@mail.gmail.com>
In-Reply-To: <0045fe6faeaa2beb63a1e63b3b7573ae06cfba38.1635438124.git.gitgitgadget@gmail.com>

On Thu, 28 Oct 2021 at 18:22, Jean-Noël Avila via GitGitGadget <gitgitgadget@gmail.com> wrote:

>  archives that it imports, it is also possible to specify Git branch names
> -manually.  To do so, write a Git branch name after each <archive/branch>
> +manually.  To do so, write a Git branch name after each <archive>/<branch>
>  parameter, separated by a colon.  This way, you can shorten the Arch

> -<archive/branch>::
> -       Archive/branch identifier in a format that `tla log` understands.
> +<archive>/<branch>::
> +       <archive>/<branch> identifier in a format that `tla log` understands.

This patch looks good to me. Maybe these "<archive>/<branch>" should go in SQs, but that should be outside the scope of this patch (and this series is big enough anyway). This last instance here adds a new instance of this pattern, but it's an existing pattern and you're following the local convention.

Martin