git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ab/config-based-hooks-2

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 18, 2022, 20:26 UTC
Message-ID
<xmqqczkossd9.fsf@gitster.g>
In-Reply-To
<220118.86a6ftowx3.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 27 quoted lines
> On Fri, Jan 14 2022, Junio C Hamano wrote:
>
>> * ab/config-based-hooks-2 (2022-01-07) 17 commits
>>  - run-command: remove old run_hook_{le,ve}() hook API
>>  - receive-pack: convert push-to-checkout hook to hook.h
>>  - read-cache: convert post-index-change to use hook.h
>>  - commit: convert {pre-commit,prepare-commit-msg} hook to hook.h
>>  - git-p4: use 'git hook' to run hooks
>>  - send-email: use 'git hook run' for 'sendemail-validate'
>>  - git hook run: add an --ignore-missing flag
>>  - hooks: convert worktree 'post-checkout' hook to hook library
>>  - hooks: convert non-worktree 'post-checkout' hook to hook library
>>  - merge: convert post-merge to use hook.h
>>  - am: convert applypatch-msg to use hook.h
>>  - rebase: convert pre-rebase to use hook.h
>>  - hook API: add a run_hooks_l() wrapper
>>  - am: convert {pre,post}-applypatch to use hook.h
>>  - gc: use hook library for pre-auto-gc hook
>>  - hook API: add a run_hooks() wrapper
>>  - hook: add 'run' subcommand
>>
>>  More "config-based hooks".
>>
>>  Will merge to 'next', with minor nits?
>>  source: <cover-v6-00.17-00000000000-20211222T035755Z-avarab@gmail.com>
>
> I'd really like that, if you're OK with it.

Obviously I am not ready to say I am OK (or not OK for that matter), and that is why I was soliciting comments by the reviewers whose comments were ignored.

And knowing how proliferate you can be when you want to, adjusting patches for reviews you received and testing the result thoroughly would be much better use of time (include the time already spent by reviewers to comment on the previous iteration), no?

Previous: Emily ShafferNext: Derrick Stolee
Message 8 of 13 in “What's cooking in git.git (Jan 2022, #04; Fri, 14)”
  1. Junio C HamanoJan 15, 2022
  2. Elijah NewrenJan 16, 2022
  3. Junio C HamanoJan 17, 2022
  4. ab/grep-patterntype (was: What's cooking in git.git (Jan 2022, #04; Fri, 14))Ævar Arnfjörð Bjarmason, Jan 18, 2022
  5. ab/config-based-hooks-2 (was: What's cooking in git.git (Jan 2022, #04; Fri, 14))Ævar Arnfjörð Bjarmason, Jan 18, 2022
  6. Glen ChooJan 18, 2022
  7. Emily ShafferJan 19, 2022
  8. Junio C HamanoJan 18, 2022
  9. ds/sparse-checkout-requires-per-worktree-config (was Re: What's cooking in git.git (Jan 2022, #04; Fri, 14))Derrick Stolee, Jan 18, 2022
  10. Junio C HamanoJan 18, 2022
  11. ar/submodule-update (was Re: What's cooking in git.git (Jan 2022, #04; Fri, 14))Glen Choo, Jan 19, 2022
  12. Junio C HamanoJan 19, 2022
  13. Phillip WoodJan 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.