Re: ab/config-based-hooks-2 (was: What's cooking in git.git (Jan 2022, #04; Fri, 14))
- From
Glen Choo <chooglen@google.com>
- Date
- Jan 18, 2022, 19:49 UTC
- Message-ID
- <kl6ltue0ygcq.fsf@chooglen-macbookpro.roam.corp.google.com>
- In-Reply-To
- <220118.86a6ftowx3.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 34 quoted lines
> On Fri, Jan 14 2022, Junio C Hamano wrote:
>
>> * ab/config-based-hooks-2 (2022-01-07) 17 commits
>> - run-command: remove old run_hook_{le,ve}() hook API
>> - receive-pack: convert push-to-checkout hook to hook.h
>> - read-cache: convert post-index-change to use hook.h
>> - commit: convert {pre-commit,prepare-commit-msg} hook to hook.h
>> - git-p4: use 'git hook' to run hooks
>> - send-email: use 'git hook run' for 'sendemail-validate'
>> - git hook run: add an --ignore-missing flag
>> - hooks: convert worktree 'post-checkout' hook to hook library
>> - hooks: convert non-worktree 'post-checkout' hook to hook library
>> - merge: convert post-merge to use hook.h
>> - am: convert applypatch-msg to use hook.h
>> - rebase: convert pre-rebase to use hook.h
>> - hook API: add a run_hooks_l() wrapper
>> - am: convert {pre,post}-applypatch to use hook.h
>> - gc: use hook library for pre-auto-gc hook
>> - hook API: add a run_hooks() wrapper
>> - hook: add 'run' subcommand
>>
>> More "config-based hooks".
>>
>> Will merge to 'next', with minor nits?
>> source: <cover-v6-00.17-00000000000-20211222T035755Z-avarab@gmail.com>
>
> I'd really like that, if you're OK with it.
>
> I.e. I could re-roll it, but those comments are relatively minor, and in
> any case will be addressed eventually by subsequent to-be-submitted
> parts of the hook.[ch] API conversion.
>
> So unless Emily or Glen have strong objections I think it makes sense to
> mark it for 'next'. Thanks!No strong objections from me :) The minor comments can be cleaned up, and some might presumably become obsolete later?