Re: the state of diff_free() and release_revisions()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 20, 2022, 17:23 UTC
- Message-ID
- <xmqqczg8jeya.fsf@gitster.g>
- In-Reply-To
- <220520.86pmk81a9z.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 5 quoted lines
> AFAICT the current status in this area is that with 2cc712324d5 (Merge > branch 'rs/fast-export-pathspec-fix', 2022-05-04) and 5048b20d1c2 (Merge > branch 'rs/format-patch-pathspec-fix', 2022-05-04) merged the known bugs > related to this have been fixed, along with 3da993f2e63 (Merge branch > 'jc/diff-tree-stdin-fix', 2022-04-28).
There is another possible known breakage around "diff -I --cc" reported, no?
https://lore.kernel.org/git/a6a14213-bc82-d6fb-43dd-5a423c40a4f8@web.de/
> Not coincidentally around the same time my ab/plug-leak-in-revisions got > un-marked for "next" from [1] to [2], and I'm looking for a path forward > for this whole thing...
I think this was not because it had known bugs but only because we wanted to avoid distractions and too much churns in the tree.
I think it is a good time to reactivate it; Phillip Wood took a serious look at the latest round, if I am reading [*] correctly.
* https://lore.kernel.org/git/2cc2d026-1496-1ed9-838b-6fdf8cfba285@gmail.com/
Thanks.