Re: [PATCH] 2.36 fast-export regression fix

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 30, 2022, 20:50 UTC
Message-ID: <xmqq35hu8feo.fsf@gitster.g>
In-Reply-To: <2c988c7b-0efe-4222-4a43-8124fe1a9da6@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 11 quoted lines

> e900d494dc (diff: add an API for deferred freeing, 2021-02-11) added a
> way to allow reusing diffopts: the no_free bit.  244c27242f (diff.[ch]:
> have diff_free() call clear_pathspec(opts.pathspec), 2022-02-16) made
> that mechanism mandatory.
>
> git fast-export doesn't set no_free, so path limiting stopped working
> after the first commit.  Set the flag and add a basic test to make sure
> only changes to the specified files are exported.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---

Both format-patch fix and this one look good to me.

We have UNLEAK() in format-patch so that the fix will not result in additional false positives from the leak checker. But this one, we didn't have UNLEAK() so this may start tickling the leak checker again. We may need to add UNLEAK() at some point.

Stopping a leak checker from complaining about a known singleton leak that is at the top-level (i.e. does not become bigger with the data) by spending extra cycles is pointless, compared to using UNLEAK() to do the same, and it is doubly misguided if it breaks the behaviour X-<.

Will queue both, thanks.