Re: [PATCH] ci: update 'static-analysis' to Ubuntu 22.04

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 26, 2022, 16:46 UTC
Message-ID: <xmqqczcnymtd.fsf@gitster.g>
In-Reply-To: <Ywh6v8oo3nRl/O5h@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

>> But the fix here isn't to delete unused.cocci, but to hold off on the
>> UNUSEwork D() patches until we figure out how to make coccinelle jive with
>> them.
>
> Yeah, my general skepticism and disappointment above notwithstanding,
> this seems like the best path forward from here. I tried a few other
> tricks (like --macro-file and --iso-file), but if its parser chokes, I
> don't think there's much we can do about it. Even if we wrote a patch to
> coccinelle itself (and I have no interest in doing that myself), it
> would take a while to become available.

If it is just a single unused.cocci, I would actually think removing it would be a much better path forward. UNUSED() that renames to help folks without checking compilers would help noticing bad code much earlier than unused.cocci many contributors are not running themselves anyway.