Re: [PATCH 0/2] git-compat-util.h: change UNUSED(var) to UNUSED

From: Jeff King <peff@peff.net>
Date: Aug 26, 2022, 07:52 UTC
Message-ID: <Ywh7ppVFk6VK1Ybs@coredump.intra.peff.net>
In-Reply-To: <cover-0.2-00000000000-20220825T170709Z-avarab@gmail.com>

On Thu, Aug 25, 2022 at 07:09:47PM +0200, Ævar Arnfjörð Bjarmason wrote:

> Ævar Arnfjörð Bjarmason (2):
>   git-compat-util.h: use "UNUSED", not "UNUSED(var)"
>   git-compat-util.h: use "deprecated" for UNUSED variables

So I don't love this, as I do find the resulting syntax harder to read. But I don't really see a way around it to keep coccinelle functioning, so it seems like the best (only?) path forward.

The patches themselves look OK to me (though I admit my eyes glazed over halfway through the first one; I assume you used a regex. I'll have to do the same for the other 100+ patches I have in reserve).

-Peff