Re: [PATCH v2 6/8] commit-reach: implement ahead_behind() logic

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 15, 2023, 16:03 UTC
Message-ID: <xmqqcz5aovc6.fsf@gitster.g>
In-Reply-To: <230315.86cz5axgny.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 15 quoted lines

>> +	/**
>> +	 * These values store the computed counts for each side of the
>> +	 * symmetric difference:
>> +	 *
>> +	 * 'ahead' stores the number of commits reachable from the tip
>> +	 * and not reachable from the base.
>> +	 *
>> +	 * 'behind' stores the number of commits reachable from the base
>> +	 * and not reachable from the tip.
>> +	 */
>> +	unsigned int ahead;
>> +	unsigned int behind;
>
> Even though this is the tip of the iceberg in terms of our codebase
> overall, can't we just use "size_t" for counts in new APIs?

I personally do not see a point in becoming so dogmatic. Plain (possibly) 32-bit integers have their places in the code.