Re: [PATCH v2 0/8] ref-filter: ahead/behind counting, faster --merged option

From: Derrick Stolee <derrickstolee@github.com>
Date: Mar 15, 2023, 13:54 UTC
Message-ID: <bfade752-6468-95a8-433b-44dc1d13413d@github.com>
In-Reply-To: <230315.86lejyxi13.gmgdl@evledraar.gmail.com>

On 3/15/2023 9:22 AM, Ævar Arnfjörð Bjarmason wrote:

Show 14 quoted lines

> 
> On Fri, Mar 10 2023, Derrick Stolee via GitGitGadget wrote:
> 
>> At $DAYJOB, we have used a custom 'ahead-behind' builtin in our fork of Git
>> for lots of reasons. The main goal of the builtin is to compare multiple
>> references against a common base reference. The comparison is number of
>> commits that are in each side of the symmtric difference of their reachable
>> sets. A commit C is "ahead" of a commit B by the number of commits in B..C
>> (reachable from C but not reachable from B). Similarly, the commit C is
>> "behind" the commit B by the number of commits in C..B (reachable from B but
>> not reachable from C).
> 
> I have a local change to get rid of the various "the_repository" macros,
> which a merge of this in "seen" conflicted with (semantically).

Thanks for doing that important refactoring.

> The below patch on top of "seen" will fix it, could you please squash it
> in in the appropriate places?

Got it. Thanks. v3 will arrive later today with those changes and the recommended strvec changes.

Thanks, -Stolee