Re: [PATCH 1/2] fuzz: fix fuzz test build rules

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 19, 2024, 22:46 UTC
Message-ID: <xmqqcytxhrgs.fsf@gitster.g>
In-Reply-To: <9332e225e44b29be25d10229b05f0b9775b85568.1705700054.git.steadmon@google.com>

Josh Steadmon <steadmon@google.com> writes:

> @@ -762,7 +763,7 @@ fuzz-objs: $(FUZZ_OBJS)
>  # Always build fuzz objects even if not testing, to prevent bit-rot.
>  all:: $(FUZZ_OBJS)

So, this is what you referred to in your proposed log message. We do build objects to prevent bit-rot, but we do not link, so it is merely half a protection.

> ...
>  fuzz-all: $(FUZZ_PROGRAMS)

But there is this target. I wonder if it makes it even better to update the "always build fuzz objects" one? Given that some folks may not have the necessary clang toochain for linking, it may probably be a bit too much, perhaps?

It definitely is an improvement to build them in the CI environment, like you have in [2/2].

Thanks.  Will queue.