Re: [PATCH 1/2] fuzz: fix fuzz test build rules
- From
Josh Steadmon <steadmon@google.com>
- Date
- Mar 4, 2024, 18:57 UTC
- Message-ID
- <ZeYZolhLCftYALYU@google.com>
- In-Reply-To
- <xmqqcytxhrgs.fsf@gitster.g>
On 2024.01.19 14:46, Junio C Hamano wrote:
Show 17 quoted lines
> Josh Steadmon <steadmon@google.com> writes: > > > @@ -762,7 +763,7 @@ fuzz-objs: $(FUZZ_OBJS) > > # Always build fuzz objects even if not testing, to prevent bit-rot. > > all:: $(FUZZ_OBJS) > > So, this is what you referred to in your proposed log message. We > do build objects to prevent bit-rot, but we do not link, so it is > merely half a protection. > > > ... > > fuzz-all: $(FUZZ_PROGRAMS) > > But there is this target. I wonder if it makes it even better to > update the "always build fuzz objects" one? Given that some folks > may not have the necessary clang toochain for linking, it may > probably be a bit too much, perhaps?
Indeed, this would have caught the previous common-main issue. I'll send a followup to fix this, thanks for the suggestion!