git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] fuzz: fix fuzz test build rules

From
Josh Steadmon <steadmon@google.com>
Date
Mar 4, 2024, 18:57 UTC
Message-ID
<ZeYZolhLCftYALYU@google.com>
In-Reply-To
<xmqqcytxhrgs.fsf@gitster.g>
On 2024.01.19 14:46, Junio C Hamano wrote:
Show 17 quoted lines
> Josh Steadmon <steadmon@google.com> writes:
> 
> > @@ -762,7 +763,7 @@ fuzz-objs: $(FUZZ_OBJS)
> >  # Always build fuzz objects even if not testing, to prevent bit-rot.
> >  all:: $(FUZZ_OBJS)
> 
> So, this is what you referred to in your proposed log message.  We
> do build objects to prevent bit-rot, but we do not link, so it is
> merely half a protection.
> 
> > ...
> >  fuzz-all: $(FUZZ_PROGRAMS)
> 
> But there is this target.  I wonder if it makes it even better to
> update the "always build fuzz objects" one?  Given that some folks
> may not have the necessary clang toochain for linking, it may
> probably be a bit too much, perhaps?

Indeed, this would have caught the previous common-main issue. I'll send a followup to fix this, thanks for the suggestion!

Previous: Junio C HamanoNext: Josh Steadmon
Message 4 of 6 in “Run limited fuzz tests in GitHub CI”
  1. 0/2 Run limited fuzz tests in GitHub CIJosh Steadmon, Jan 19, 2024
  2. 1/2 fuzz: fix fuzz test build rulesJosh Steadmon, Jan 19, 2024
  3. Junio C HamanoJan 19, 2024
  4. Josh SteadmonMar 4, 2024
  5. 2/2 ci: build and run minimal fuzzers in GitHub CIJosh Steadmon, Jan 19, 2024
  6. Junio C HamanoJan 19, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.