Re: [PATCH] use C99 declaration of variable in for() loop

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 15, 2024, 17:33 UTC
Message-ID: <xmqqcysxskd9.fsf@gitster.g>
In-Reply-To: <20240215094243.147057-1-gitter.spiros@gmail.com>

Elia Pinto <gitter.spiros@gmail.com> writes:

Show 5 quoted lines

> With the exception of cbtree.c, which would need initial
> reworking to remove the usage of goto, it expands the
> use of variable scope reduction in for loops as
> permitted by the C99 standard, which was first introduced
> in the git codebase with commit 44ba10d6.

Thanks, but ...

Our test balloon may have proven that nobody will be inconvenienced, and it does mean we can be liberal using it when we add new code or update existing loops "while at it", but I personally do not think such a code churn is very welcome.