Re: [PATCH] use C99 declaration of variable in for() loop

From: Elia Pinto <gitter.spiros@gmail.com>
Date: Feb 15, 2024, 18:56 UTC
Message-ID: <CA+EOSBktLGnzi+DjOTVv9_cVNsM_fjEKiF9kWnaYrGtvGJ-Kdg@mail.gmail.com>
In-Reply-To: <xmqqcysxskd9.fsf@gitster.g>

Il giorno gio 15 feb 2024 alle ore 18:33 Junio C Hamano <gitster@pobox.com> ha scritto:

Show 15 quoted lines

>
> Elia Pinto <gitter.spiros@gmail.com> writes:
>
> > With the exception of cbtree.c, which would need initial
> > reworking to remove the usage of goto, it expands the
> > use of variable scope reduction in for loops as
> > permitted by the C99 standard, which was first introduced
> > in the git codebase with commit 44ba10d6.
>
> Thanks, but ...
>
> Our test balloon may have proven that nobody will be inconvenienced,
> and it does mean we can be liberal using it when we add new code or
> update existing loops "while at it", but I personally do not think
> such a code churn is very welcome.

Thank you for your reply. I can understand that, clearly. However, this means that extensive code refactoring contributions are never welcome. I am not saying this is a problem, but just an observation.

Best