Re: [PATCH v3 2/4] builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 13, 2024, 21:32 UTC
Message-ID: <xmqqcyl7w87y.fsf@gitster.g>
In-Reply-To: <7becd3751fc73a51a1791427b2232fc94f1c9ae9.1726262178.git.gitgitgadget@gmail.com>

"John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines

> From: John Cai <johncai86@gmail.com>
>
> Instead of including USE_THE_REPOSITORY_VARIABLE by default on every
> builtin, remove it from builtin.h and add it to all the builtins that
> reference the_repository.

I'll do
    "reference the_repository" -> "include builtin.h"
while queuing.

The next step removes #define from the ones that do not reference the_repository, and because it is not empty, by definition, this step cannot be adding #define only to those that reference the_repository.

Show 5 quoted lines

> Also, remove the include statement for repository.h since it gets
> brought in through builtin.h.
>
> The next step will be to migrate each builtin
> from having to use the_repository.

Thanks.