Re: [PATCH v3] builtin/gc: fix crash when running `git maintenance start`

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2024, 17:09 UTC
Message-ID: <xmqqcyk7lwa4.fsf@gitster.g>
In-Reply-To: <a5b1433abfd84cb627efc17f52e0d644ee207bb0.1728538282.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> +	write_script script/systemctl <<-\EOF &&
> +	echo "$*" >>../systemctl.log
> +	EOF

Ah, for the purpose of this test, we _know_ in which directory the "systemctl" will be spawned, so this is good enough for us, of course.

Show 5 quoted lines

> +	git init repo &&
> +	(
> +		cd repo &&
> +		sane_unset GIT_TEST_MAINT_SCHEDULER &&
> +		PATH="$PWD/../script:$PATH" git maintenance start --scheduler=systemd

I suspect we can use the same idea and add a relative path in $PATH for the test, perhaps, even though it is not a good coding discipline. If $PWD, instead of $(pwd), works, it is perfectly OK.

Will queue.  Thanks.