Re: [PATCH v2] builtin/gc: fix crash when running `git maintenance start`

From: Derrick Stolee <stolee@gmail.com>
Date: Oct 9, 2024, 13:13 UTC
Message-ID: <26e589c7-7625-409c-9913-9ed4b8ef9808@gmail.com>
In-Reply-To: <5798c31e1ef9346e7faf73f8c80b32c436937a8a.1728455715.git.ps@pks.im>

On 10/9/24 3:08 AM, Patrick Steinhardt wrote:

Show 5 quoted lines

> There's a single fix compared to v1, where Stolee mentioned that the
> added test fails on both Windows and macOS because the "crontab"
> scheduler isn't available there. I've adapted the test to instead use
> the "systemd" scheduler, which _is_ available on all platforms when the
> systemctl(1) binary can be found.

I do appreciate that you are making the test work on all platforms instead of my workaround to avoid the test on mac and Windows.

I was initially confused by your description saying that systemctl is available on these platforms, because it isn't for my machines. But a way to rephrase what you mean is "Git has compile-time expectations that crontab doesn't exist for macOS and Windows, but Git checks for 'systemctl' on the PATH regardless of compiled platform."

Thus, placing a systemctl script works for these platforms even when they don't have systemctl available normally.

I'm happy with this version.

Thanks, -Stolee