Re: undefined behavior in unit tests, was Re: [PATCH v3 3/3] reftable: prevent 'update_index' changes after adding records
Patrick Steinhardt <ps@pks.im> writes:
Show 11 quoted lines
>> if (!check(ptr))
>> return;
>>
>> As we're in the process of switching to using clar which does exit the text
>> function if a check fails (that means there may be leaks on failure but if
>> the test is failing then I don't think we should be worrying about leaks) I
>> don't know if it is worth fixing these or not. I guess it depends if there
>> are the list of targets for Seyi's Outreachy project.
>
> Ah, yes, should've read your mail first, as you're saying basically the
> same as I did :)
Yup, I 100% agree with both of you. Thanks.