Re: undefined behavior in unit tests, was Re: [PATCH v3 3/3] reftable: prevent 'update_index' changes after adding records

From: Jeff King <peff@peff.net>
Date: Feb 3, 2025, 15:38 UTC
Message-ID: <20250203153821.GC4165842@coredump.intra.peff.net>
In-Reply-To: <CAOLa=ZRCb4KHKNkW=kuGhiR7B-aV73KV32DqjX4RM0fDP1gMww@mail.gmail.com>

On Mon, Feb 03, 2025 at 07:20:16AM -0800, Karthik Nayak wrote:

> Like Phillip and Patrick mentioned, this should go away since we're
> moving to using the clar test framework. I think it makes sense to keep
> this as is to stay consistent with the rest of code in this file for
> now. It is ugly, but seems like that would be simpler while migrating.

Yeah, definitely not worth addressing this single case. I was more interested in the overall trend, but it sounds like there are plans there already.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.