Re: [PATCH v2 0/5] meson: wire up support for benchmarks

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 18, 2025, 23:02 UTC
Message-ID: <xmqqcyd99ipm.fsf@gitster.g>
In-Reply-To: <Z_-Nu27GeW0o2E0f@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 15 quoted lines

>> This one
>> 
>>     https://github.com/git/git/actions/runs/14406901394
>> 
>> is from last week without the earlier iteration of this topic, which
>> fails a few meson jobs.
>> 
>> linux-meson job that fails with
>> 
>> meson.build:689:19: ERROR: Command `/usr/bin/git -C /__w/git/git ls-files --deduplicate '*.h' ':!contrib' ':!compat/inet_ntop.c' ':!compat/inet_pton.c' ':!compat/nedmalloc' ':!compat/obstack.*' ':!compat/poll' ':!compat/regex' ':!sha1collisiondetection' ':!sha1dc' ':!t/unit-tests/clar' ':!t/unit-tests/clar' ':!t/t[0-9][0-9][0-9][0-9]*'` failed with status 128.
>
> Hm, curious. These lines have been moved here by kn/meson-hdr-check, but
> the logic already existed beforehand. I've Cc'd Karthik -- it would
> probably make sense to investigate (and ideally also fix) the issue as
> part of that series.

Indeed. I tentatively kicked meson-hdr-check topic out of 'seen' and the CI seems to be a lot happier. What is curious is that in my local environment 'seen' with meson-hdr-check topic did not fail for me.