Re: [PATCH v4 0/5] meson: wire up support for benchmarks
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Apr 25, 2025, 08:06 UTC
- Message-ID
- <CAP8UFD1ovdQdfvLMvfPi8fz5S82n+8mfjK7ECqoQUMW2p-khjA@mail.gmail.com>
- In-Reply-To
- <20250425-pks-meson-benchmarks-v4-0-6b89555052c3@pks.im>
On Fri, Apr 25, 2025 at 9:28 AM Patrick Steinhardt <ps@pks.im> wrote:
Show 7 quoted lines
> Changes in v4: > - The patch series was rebased on top of f65182a99e5 (The ninth batch, > 2025-04-24). This is due to a conflict with ps/test-wo-perl-prereq. > - Introduce a 'benchmarks' option. This allows developers to require > benchmarks as desired. By default, we auto-detect whether the host > system has all dependencies available and enable or disable them > accordingly.
Nice!
> - Report whether or not benchmarks are enabled via `summary()`. > - Our benchmarks depend on Perl, so add this dependency accordingly.
Nice too!
[...]
Show 5 quoted lines
> Range-diff versus v3: > > 1: 2375a16c2c0 = 1: 174804805c2 t/perf: fix benchmarks with alternate repo formats > 2: 69782035246 = 2: 41faa3d9b3b t/perf: use configured PERL_PATH > 3: cca40e9dd0e = 3: 87ea3ab1a45 t/perf: fix benchmarks with out-of-tree builds
In https://lore.kernel.org/git/aAc8f52rJ8ATncVc@pks.im/ you said you would try to paraphrase some explanations about how GIT_BUILD_DIR is computed, but it looks like there aren't any changes in the patch since the previous version :-(