Re: Test failure in p5332-multi-pack-reuse.sh

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 22, 2025, 04:06 UTC
Message-ID: <xmqqcyd46dsb.fsf@gitster.g>
In-Reply-To: <292ae7a3-2aad-1f22-2afe-739ec921d6b7@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> writes:

Show 9 quoted lines

> Sidenote: on GitHub CI, I could not demonstrate the failure on Linux
> because all Linux jobs run in containers, and the images we use do 
> not have Git installed, such that actions/checkout@v4 uses the GitHub
> API to download the repository instead of cloning it [3]. This leads 
> die_if_build_dir_not_repo from perf-lib.sh to fail with
> "No $GIT_PERF_REPO defined, and your build directory is not a repo" [4].
> We could fix that by installing the 'git' package before the 'actions/checkout'
> step, but we would need to account for the different package managers of 
> the distros we test on.

Not limited to this topic, but wouldn't it make more sense to first run install-dependencies (including "/usr/bin/git") and then invoke the actions/checkout thing, I have to wonder. We were bitten by a separate topic due to the same issue quite recently.

Thanks.