git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Test failure in p5332-multi-pack-reuse.sh

From
Philippe Blain <levraiphilippeblain@gmail.com>
Date
Apr 22, 2025, 02:01 UTC
Message-ID
<292ae7a3-2aad-1f22-2afe-739ec921d6b7@gmail.com>
Hi Taylor,

I noticed that p5332-multi-pack-reuse.sh, which you added in ba47d88795 (t/perf: add performance tests for multi-pack reuse, 2023-12-14) fails early on in the second test ("setup bitmaps for 1-pack scenario"). Since perf tests run with '--immediate', I do not know if further tests in that file also fail. It is reproducible on macOS [1] as well as Linux [2] (I don't know if these logs are public though).

I also tested on Linux on version 2.44.0 which is the first release in which this test was added, and it also failed similarily.

Sidenote: on GitHub CI, I could not demonstrate the failure on Linux
because all Linux jobs run in containers, and the images we use do 
not have Git installed, such that actions/checkout@v4 uses the GitHub
API to download the repository instead of cloning it [3]. This leads 
die_if_build_dir_not_repo from perf-lib.sh to fail with
"No $GIT_PERF_REPO defined, and your build directory is not a repo" [4].
We could fix that by installing the 'git' package before the 'actions/checkout'
step, but we would need to account for the different package managers of 
the distros we test on.
Cheers,
Philippe.

[1] https://github.com/phil-blain/git/actions/runs/14580975799/job/40897421311#step:4:896 [2] https://gitlab.com/phil-blain/git/-/jobs/9780586827#L2889 [3] https://github.com/phil-blain/git/actions/runs/14580975799/job/40897421399#step:4:28 [4] https://github.com/phil-blain/git/actions/runs/14580975799/job/40897421399#step:8:838

Next: Junio C Hamano
Message 1 of 6 in “Test failure in p5332-multi-pack-reuse.sh”
  1. Philippe BlainApr 22, 2025
  2. Junio C HamanoApr 22, 2025
  3. p5332: drop "+" from --stdin-packs inputJeff King, Apr 22, 2025
  4. Junio C HamanoApr 22, 2025
  5. Jeff KingMay 1, 2025
  6. Taylor BlauApr 22, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.