git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] stash: fix and improve "git stash -p <pathspec>"

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 3, 2025, 22:11 UTC
Message-ID
<xmqqcybkh3wg.fsf@gitster.g>
In-Reply-To
<cover.1747733203.git.phillip.wood@dunelm.org.uk>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 22 quoted lines
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> "git stash -p <pathspec>" should imply "git stash push -p <pathspec>"
> but that was broken by a code cleanup in c3713cede7 (stash: eliminate
> crude option parsing, 2020-02-17). This regression is fixed in the
> first patch. Although "-p" implies the "push" subcommand "--patch"
> has never implied "push". That is fixed in the second patch.
>
> Thanks to Junio for his comments on V1.
>
> Changes since V1:
>  - Split out the regression fix into its own patch
>
> Base-Commit: 1a8a4971cc6c179c4dd711f4a7f5d7178f4b3ab7
> Published-As: https://github.com/phillipwood/git/releases/tag/pw%2Fstash-assume-push-with-dash-p%2Fv2
> View-Changes-At: https://github.com/phillipwood/git/compare/1a8a4971c...98ad3de97
> Fetch-It-Via: git fetch https://github.com/phillipwood/git pw/stash-assume-push-with-dash-p/v2
>
>
> Phillip Wood (2):
>   stash: allow "git stash -p <pathspec>" to assume push again
>   stash: allow "git stash [<options>] --patch <pathspec>" to assume push

Are other people interested in this work? I haven't seen any comments other than a few nitpicky one form mine, and want to (1) gauge the interest in the fix, and (2) see how well reviewed it is (and my review or reading over the patches again would not count all that much here).

Thanks.
Previous: Junio C HamanoNext: Martin Ågren
Message 11 of 18 in “stash: allow "git stash -p <pathspec>" to assume push again”
  1. stash: allow "git stash -p <pathspec>" to assume push againPhillip Wood, May 16, 2025
  2. Junio C HamanoMay 16, 2025
  3. Phillip WoodMay 20, 2025
  4. 0/2 stash: fix and improve "git stash -p <pathspec>"Phillip Wood, May 20, 2025
  5. 1/2 stash: allow "git stash -p <pathspec>" to assume push againPhillip Wood, May 20, 2025
  6. Martin ÅgrenJun 6, 2025
  7. Phillip WoodJun 6, 2025
  8. 2/2 stash: allow "git stash [<options>] --patch <pathspec>" to assume pushPhillip Wood, May 20, 2025
  9. Martin ÅgrenJun 6, 2025
  10. Junio C HamanoMay 21, 2025
  11. Junio C HamanoJun 3, 2025
  12. Martin ÅgrenJun 6, 2025
  13. 0/2 stash: fix and improve "git stash -p <pathspec>"Phillip Wood, Jun 7, 2025
  14. 1/2 stash: allow "git stash -p <pathspec>" to assume push againPhillip Wood, Jun 7, 2025
  15. 2/2 stash: allow "git stash [<options>] --patch <pathspec>" to assume pushPhillip Wood, Jun 7, 2025
  16. Martin ÅgrenJun 7, 2025
  17. Phillip WoodJun 9, 2025
  18. Martin ÅgrenJun 10, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.