Re: [PATCH v2 0/2] stash: fix and improve "git stash -p <pathspec>"

From: Martin Ågren <martin.agren@gmail.com>
Date: Jun 6, 2025, 11:39 UTC
Message-ID: <CAN0heSpRWoiPh-c9y27unLgx18VNiHwJvnPiUERM_KSiP-39=g@mail.gmail.com>
In-Reply-To: <xmqqcybkh3wg.fsf@gitster.g>

On Wed, 4 Jun 2025 at 00:11, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

>
> > Phillip Wood (2):
> >   stash: allow "git stash -p <pathspec>" to assume push again
> >   stash: allow "git stash [<options>] --patch <pathspec>" to assume push
>
> Are other people interested in this work?  I haven't seen any
> comments other than a few nitpicky one form mine, and want to (1)
> gauge the interest in the fix, and (2) see how well reviewed it is
> (and my review or reading over the patches again would not count all
> that much here).

On reading the patches, I realized that I have some interest in this. I left some comments. Most of them amount to thinking out loud, but I do think that the new test could do a bit better at proving that the (fixed/improved) implementation actually ends up picking up `-p` at all.

A nice, pleasant read. The series has a well-defined focus.

Martin