Re: [PATCH v3 2/8] meson: stop printing 'https' option twice in our summaries

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 9, 2025, 15:17 UTC
Message-ID: <xmqqcya9pf5o.fsf@gitster.g>
In-Reply-To: <20250709-b4-pks-meson-cleanups-v3-2-29ab15b9ab85@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 8 quoted lines

> The value for the 'https' backend option is printed twice: once via the
> summary of auto-detected features and once via our summary of backends.
> Drop it from the former summary.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  meson.build | 1 -
>  1 file changed, 1 deletion(-)

Good eyes. To me the distinction between "Auto-detected features" and "Backends" feel a bit blurry, but most of the things in the former are what dependency() returned, while https_backend is very much driven by custom code of ours, so removing from "Auto-detected" does make senseto me.

Thanks.

Show 12 quoted lines

> diff --git a/meson.build b/meson.build
> index 4ee1a55b0bb..0ed00254ef3 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2200,7 +2200,6 @@ summary({
>    'expat': expat.found(),
>    'gettext': intl.found(),
>    'gitweb': gitweb_option.allowed(),
> -  'https': https_backend,
>    'iconv': iconv.found(),
>    'pcre2': pcre2.found(),
>    'perl': perl_features_enabled,