Re: [PATCH 1/8] meson: stop discovering native version of Python

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 9, 2025, 06:16 UTC
Message-ID: <aG4JNtURJpMOTls7@pks.im>
In-Reply-To: <4ql5wzqvcoxrcbi6cznavtnfzwmh72tevixwgotvsx4kzkbljv@a55yhjqqqnym>

On Tue, Jul 08, 2025 at 02:38:49PM -0500, Justin Tobler wrote:

Show 21 quoted lines

> On 25/07/03 11:28AM, Patrick Steinhardt wrote:
> > diff --git a/meson.build b/meson.build
> > index 7fea4a34d68..21fdff0f496 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -866,9 +866,8 @@ if host_machine.system() == 'cygwin' or host_machine.system() == 'windows'
> >  endif
> >  build_options_config.set_quoted('X', executable_suffix)
> >  
> > -python = import('python').find_installation('python3', required: get_option('python'))
> > -target_python = find_program('python3', native: false, required: python.found())
> > -if python.found()
> > +target_python = find_program('python3', native: false, required: get_option('python'))
> > +if target_python.found()
> 
> Ok, so here we are not actually using python to build, but instead need
> to know whether to include this build configuration which is dependent
> on the target host having python. Makes sense.
> 
> It might be nice to leave a comment here to explain this. The changes in
> this patch look good though.

Makes sense, will do.

Patrick