Re: [PATCH v3 3/8] git: allow alias-shadowing deprecated builtins

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 8, 2025, 20:47 UTC
Message-ID: <xmqqcy80wu0y.fsf@gitster.g>
In-Reply-To: <eec01cbac16596c5e117843ae86956e1f66ec097.1757345711.git.code@khaugsbakk.name>

kristofferhaugsbakk@fastmail.com writes:

Show 5 quoted lines

> +static int is_deprecated_command(const char *cmd)
> +{
> +	return !strcmp(cmd, "whatchanged") ||
> +	       !strcmp(cmd, "pack-redundant");
> +}

This is somewhat a shame as you introduced the DEPRECATED bit to annotate entries in "struct cmd_struct commands[]" array. Shouldn't this be moved to git.c and taught to consult that array instead?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.