Re: [PATCH 2/4] whatchanged: tell users the git-log(1) equivalent

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Aug 27, 2025, 17:08 UTC
Message-ID: <28875b20-91d9-44ed-bad1-d0a7aedfbfbd@app.fastmail.com>
In-Reply-To: <xmqq1pow3e4b.fsf@gitster.g>

On Wed, Aug 27, 2025, at 18:48, Junio C Hamano wrote:

Show 14 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> kristofferhaugsbakk@fastmail.com writes:
>>
>>> -	if (!cfg.i_still_use_this)
>>> -		you_still_use_that("git whatchanged");
>>> +        if (!cfg.i_still_use_this)
>>> +		you_still_use_that("git whatchanged",
>>
>> I spot a whitespace breakage here.  I didn't check if there are
>
> Sorry, I read the patch backwards.  You are fixing an existing
> whitespace breakage, which is very much appreciated, as this is
> immediate vicinity of the real change of this topic.

No, I did inadvertently replace the tab indents with spaces. I’ll have to configure my editor better. I’ll fix it.

(`ci/check-whitespace.sh v2.51.0` turned out to be helpful for me here)

-- 
Kristoffer Haugsbakk