git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] perl: also mark git-contacts executable

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 11, 2025, 20:18 UTC
Message-ID
<xmqqcy5owcel.fsf@gitster.g>
In-Reply-To
<CALnO6CA2uLjWg_kwbaEGd+TZP4qQEBMus6HRVbo7Bz9oHdoYxA@mail.gmail.com>
"D. Ben Knoble" <ben.knoble+github@gmail.com> writes:
Show 27 quoted lines
> On Tue, Nov 11, 2025 at 1:59 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> "D. Ben Knoble" <ben.knoble+github@gmail.com> writes:
>>
>> > When installing git-contacts with Meson via -Dcontrib=contacts, the
>> > default Perl generation fails to mark it executable. As a result, "git
>> > contacts" reports "'contacts' is not a git command."
>> >
>> > Unlike generate-script.sh, we aren't testing the basename here; so, glob
>> > the script name in the case arm to match wherever the input comes from.
>> >
>> > Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
>> > ---
>> >
>> > A small typo fix for the commit message, thanks to Patrick.
>> >
>> > v1: https://lore.kernel.org/git/7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com/
>>
>> Together with the html one, these patches match what I have already
>> queued with local tweaks, so I won't replace them (they are in
>> 'next' now).
>>
>> Thanks.
>
> Ah, sounds good. That was one of the things I wanted to ask by "shall
> I send v2 or does Junio mind the trivial fix," and I should have been
> more direct.
No, your question did reach me loud and clear.
Previous: D. Ben Knoble
Message 8 of 8 in “perl: also mark git-contacts executable”
  1. perl: also mark git-contacts executableD. Ben Knoble, Nov 4, 2025
  2. Patrick SteinhardtNov 6, 2025
  3. Ben KnobleNov 6, 2025
  4. Junio C HamanoNov 6, 2025
  5. perl: also mark git-contacts executableD. Ben Knoble, Nov 11, 2025
  6. Junio C HamanoNov 11, 2025
  7. D. Ben KnobleNov 11, 2025
  8. Junio C HamanoNov 11, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.