From: Junio C Hamano Date: Tue, 11 Nov 2025 20:18:58 GMT Subject: Re: [PATCH v2] perl: also mark git-contacts executable Message-ID: In-Reply-To: "D. Ben Knoble" writes: > On Tue, Nov 11, 2025 at 1:59 PM Junio C Hamano wrote: >> >> "D. Ben Knoble" writes: >> >> > When installing git-contacts with Meson via -Dcontrib=contacts, the >> > default Perl generation fails to mark it executable. As a result, "git >> > contacts" reports "'contacts' is not a git command." >> > >> > Unlike generate-script.sh, we aren't testing the basename here; so, glob >> > the script name in the case arm to match wherever the input comes from. >> > >> > Signed-off-by: D. Ben Knoble >> > --- >> > >> > A small typo fix for the commit message, thanks to Patrick. >> > >> > v1: https://lore.kernel.org/git/7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com/ >> >> Together with the html one, these patches match what I have already >> queued with local tweaks, so I won't replace them (they are in >> 'next' now). >> >> Thanks. > > Ah, sounds good. That was one of the things I wanted to ask by "shall > I send v2 or does Junio mind the trivial fix," and I should have been > more direct. No, your question did reach me loud and clear.