Re: [PATCH v3] apply.c: fix -p argument parsing

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 13, 2026, 04:19 UTC
Message-ID: <xmqqcy189x98.fsf@gitster.g>
In-Reply-To: <20260313001629.GA3193660@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

>> diff --git a/t/t4120/patch b/t/t4120/patch
>
> Not related to the failure, but IMHO we should keep small data like this
> in the script itself, rather than as auxiliary files. The t/ directory
> is already quite crowded, and it is often easier to refer to it when
> it's near the tests themselves.

A very good suggestion. I actually did find it a bit annoying to see an extra file there, but somehow failed to mention it in my review. Creating one in a set-up step and reusing it would be just as simple as shipping an extra file.

Thanks.