git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] apply.c: fix -p argument parsing

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 13, 2026, 04:27 UTC
Message-ID
<xmqq34249wx3.fsf@gitster.g>
In-Reply-To
<20260313011259.GA3204960@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Getting back to your patch: why is there a CRLF here in the first place?
> Because on Windows, we check out the whole repo with CRLF conversion,
> except for a few known file types listed in .gitattributes. And that
> includes your t/t4120/patch file.
Yuck.
> Coincidentally the style suggestion I made earlier, to just inline it in
> the t4120 script itself, makes the problem go away.
Of course.  Joy of stumbling on ^W^Wworking with Windows.  Sigh...
> So I would suggest doing that as a workaround. It might be worth
> addressing the CRLF header parsing problem above, too, but I think that
> should be a separate topic.
Previous: Jeff KingNext: Junio C Hamano
Message 11 of 19 in “apply.c: fix -p argument parsing”
  1. apply.c: fix -p argument parsingMirko Faina, Mar 9, 2026
  2. Junio C HamanoMar 9, 2026
  3. apply.c: fix -p argument parsingMirko Faina, Mar 10, 2026
  4. Junio C HamanoMar 10, 2026
  5. Mirko FainaMar 10, 2026
  6. apply.c: fix -p argument parsingMirko Faina, Mar 10, 2026
  7. Junio C HamanoMar 10, 2026
  8. Jeff KingMar 13, 2026
  9. Jeff KingMar 13, 2026
  10. Jeff KingMar 13, 2026
  11. Junio C HamanoMar 13, 2026
  12. Junio C HamanoMar 13, 2026
  13. apply.c: fix -p argument parsingMirko Faina, Mar 13, 2026
  14. Junio C HamanoMar 13, 2026
  15. apply.c: fix -p argument parsingMirko Faina, Mar 16, 2026
  16. Mirko FainaMar 16, 2026
  17. Junio C HamanoMar 16, 2026
  18. Tian YuchenMar 15, 2026
  19. Mirko FainaMar 15, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.