Re: [PATCH v2] stash: expose untracked modes in create

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 1, 2026, 16:36 UTC
Message-ID: <xmqqcxtt74ys.fsf@gitster.g>
In-Reply-To: <ar5EwwEt8-ADeLdr@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 19 quoted lines

> On Thu, Oct 01, 2026 at 01:21:55PM +0900, Kazumasa Shigeta wrote:
>
> When sending a v2 in response to review feedback it's a good idea to
> both:
>
>   - Respond to the reviewer to acknowledge their feedback and/or engage
>     in a discussion.
>
>   - As part of v2, send a range-diff as well as some documentation what
>     has changed between the two versions.
>
> This ensures some netiquette in an age where we're increasingly only
> talking with AI, either directly or via a meat proxy. And makes it
> easier for the reviewer to see how exactly you have honored their
> feedback.
>
> Thanks!
>
> Patrick

Thanks for bringing this up.

A response to review on the first round should come _before_ sending v2 round of patch(es). Some people send them after v2, or immediately sending before v2, but the right time to respond is actually soon after receiving reviews on v1 and you had enough time to understand the review comments, before starting to work on v2. And then after working on v2, you would send patches. So whenever I see v1 responses come after v2 patches or soon before v2 patches, I smell that something is fishy.