Re: [PATCH v2] stash: expose untracked modes in create

From: 重田一聖 <kazumasa.shigeta@kanamei.com>
Date: Oct 1, 2026, 16:01 UTC
Message-ID: <CANUHOw3syiH81F_5q-S33Zmyfw5v_R8cS1hwgpPLqrBDQGu3FQ@mail.gmail.com>
In-Reply-To: <ar5EwwEt8-ADeLdr@pks.im>

Hi Patrick,

Thanks for pointing this out, and sorry I did not understand the expected review process here and sent v2 before replying to Phillip.

I'll reply to Phillip first and follow the proper order.

Thanks,

Kazumasa Shigeta

On Thu, 1 Oct 2026 13:32:19 +0200, Patrick Steinhardt <ps@pks.im> wrote:

Show 19 quoted lines

> On Thu, Oct 01, 2026 at 01:21:55PM +0900, Kazumasa Shigeta wrote:
>
> When sending a v2 in response to review feedback it's a good idea to
> both:
>
> - Respond to the reviewer to acknowledge their feedback and/or engage
> in a discussion.
>
> - As part of v2, send a range-diff as well as some documentation what
> has changed between the two versions.
>
> This ensures some netiquette in an age where we're increasingly only
> talking with AI, either directly or via a meat proxy. And makes it
> easier for the reviewer to see how exactly you have honored their
> feedback.
>
> Thanks!
>
> Patrick