Re: [GSoC PATCH] t5402: use test_path_* helpers instead of test -e and test -f
"Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:
Show 18 quoted lines
> On Thu Oct 29, 2026 at 4:00 PM EDT, Tilak Kumar wrote:
>> Use test_path_exists and test_path_is_missing instead of "test -e"
>> and "! test -f" in the post-merge hook tests, so that a failure
>> reports which path was unexpectedly missing or present instead of
>> failing silently.
>>
>> Signed-off-by: Tilak Kumar <raaztilak07@gmail.com>
>> ...
>>
>> test_expect_success 'post-merge from squash merge runs as expected ' '
>> GIT_DIR=clone2/.git git merge --squash $commit1 &&
>> - test -e clone2/.git/post-merge.args
>> + test_path_exists clone2/.git/post-merge.args
>> '
>>
>> test_expect_success 'post-merge from squash merge receives the right argument ' '
>
> looks correct to me.
Thanks for writing and reviewing. Queued.