git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC PATCH] t5402: use test_path_* helpers instead of test -e and test -f

From
MCMark C. Chu-Carroll <markchucarroll@fastmail.com>
Date
Oct 29, 2026, 20:17 UTC
Message-ID
<DMHLKVCPT29F.1JXB7BAOXBPYT@fastmail.com>
In-Reply-To
<20261029200024.32206-1-raaztilak07@gmail.com>
On Thu Oct 29, 2026 at 4:00 PM EDT, Tilak Kumar wrote:
Show 38 quoted lines
> Use test_path_exists and test_path_is_missing instead of "test -e"
> and "! test -f" in the post-merge hook tests, so that a failure
> reports which path was unexpectedly missing or present instead of
> failing silently.
>
> Signed-off-by: Tilak Kumar <raaztilak07@gmail.com>
> ---
>  t/t5402-post-merge-hook.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/t/t5402-post-merge-hook.sh b/t/t5402-post-merge-hook.sh
> index c77aa56421..1e222ac28f 100755
> --- a/t/t5402-post-merge-hook.sh
> +++ b/t/t5402-post-merge-hook.sh
> @@ -37,12 +37,12 @@ test_expect_success 'setup clone hooks' '
>  
>  test_expect_success 'post-merge does not run for up-to-date ' '
>  	GIT_DIR=clone1/.git git merge $commit0 &&
> -	! test -f clone1/.git/post-merge.args
> +	test_path_is_missing clone1/.git/post-merge.args
>  '
>  
>  test_expect_success 'post-merge runs as expected ' '
>  	GIT_DIR=clone1/.git git merge $commit1 &&
> -	test -e clone1/.git/post-merge.args
> +	test_path_exists clone1/.git/post-merge.args
>  '
>  
>  test_expect_success 'post-merge from normal merge receives the right argument ' '
> @@ -51,7 +51,7 @@ test_expect_success 'post-merge from normal merge receives the right argument '
>  
>  test_expect_success 'post-merge from squash merge runs as expected ' '
>  	GIT_DIR=clone2/.git git merge --squash $commit1 &&
> -	test -e clone2/.git/post-merge.args
> +	test_path_exists clone2/.git/post-merge.args
>  '
>  
>  test_expect_success 'post-merge from squash merge receives the right argument ' '
looks correct to me.
-- 
Mark Craig Chu-Carroll (@MarkChuCarroll at gitlab)
*** Software Tools/Math Geek - Software Engineer at Gitlab
*** Work Email: mcarroll@gitlab.com / markchucarroll@fastmail.com
*** Personal Blog: http://goodmath.org/blog / Personal email: markcc@gmail.com
Previous: Tilak KumarNext: Junio C Hamano
Message 2 of 3 in “t5402: use test_path_* helpers instead of test -e and test -f”
  1. t5402: use test_path_* helpers instead of test -e and test -fTilak Kumar, Oct 29, 2026
  2. Mark C. Chu-CarrollOct 29, 2026
  3. Junio C HamanoOct 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.