Re: uname check fails on Solaris due to different return value
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 12, 2026, 19:29 UTC
- Message-ID
- <xmqqcxs9j1bp.fsf@gitster.g>
- In-Reply-To
- <SJ0PR10MB578540903B4931FFD985580C8A702@SJ0PR10MB5785.namprd10.prod.outlook.com>
Jakub Kulik <jakub.kulik@oracle.com> writes:
Show 7 quoted lines
> Hi, I encountered one more minor Solaris failure. > > On Solaris, uname syscall returns non-negative value on success > and -1 on failure [1], which is different from seemingly all other > supported platforms, which return 0 on success (and still -1 on > failure). As such, the current check in version.c doesn't work on > Solaris.
It seems that POSIX.1 is pretty clear on this.
Upon successful completion, a non-negative value shall be
returned. Otherwise, -1 shall be returned and errno set to
indicate the error.Erroring upon seeing a non-zero value like the preimage of your patch below *is* buggy, and the updated code looks right.
Show 18 quoted lines
> I managed to fix this with:
>
> --- git-2.56.0/version.c
> +++ git-2.56.0/version.c
> @@ -83,7 +83,7 @@ int get_uname_info(struct strbuf *buf, u
> {
> struct utsname uname_info;
>
> - if (uname(&uname_info)) {
> + if (uname(&uname_info) < 0) {
> strbuf_addf(buf, _("uname() failed with error '%s' (%d)\n"),
> strerror(errno),
> errno);
>
>
> which *I think* should work on other platforms as well ([2]), but
> I might be missing some where this change wouldn't work. Still, I
> wanted to at least report this.Thanks. Care to make it into a real patch?