threads / discuss / 66836

uname check fails on Solaris due to different return value

Subject: uname check fails on Solaris due to different return value

## tl;dr

4 messages between Nov 12, 2026 and Nov 18, 2026.

replies: 3people: 2as markdown or json

Jakub Kulik· Nov 12, 2026, 15:52 UTC · lore
Hi, I encountered one more minor Solaris failure.
On Solaris, uname syscall returns non-negative value on success and -1 on failure [1], which is different from seemingly all other supported platforms, which return 0 on success (and still -1 on failure). As such, the current check in version.c doesn't work on Solaris.
I managed to fix this with:

--- git-2.56.0/version.c +++ git-2.56.0/version.c

@@ -83,7 +83,7 @@ int get_uname_info(struct strbuf *buf, u
 {
 	struct utsname uname_info;
 
-	if (uname(&uname_info)) {
+	if (uname(&uname_info) < 0) {
 		strbuf_addf(buf, _("uname() failed with error '%s' (%d)\n"),
 			    strerror(errno),
 			    errno);


which *I think* should work on other platforms as well ([2]), but I might be missing some where this change wouldn't work. Still, I wanted to at least report this.

Thanks and Best regards,
Jakub

[1] https://docs.oracle.com/cd/E88353_01/html/E37841/uname-2.html
    https://smartos.org/man/2/uname
[2] https://pubs.opengroup.org/onlinepubs/009604599/functions/uname.html
Junio C Hamano· Nov 12, 2026, 19:29 UTC · re: Jakub Kulik · lore

Re: uname check fails on Solaris due to different return value

Jakub Kulik <jakub.kulik@oracle.com> writes:
Show 7 quoted lines
> Hi, I encountered one more minor Solaris failure.
>
> On Solaris, uname syscall returns non-negative value on success
> and -1 on failure [1], which is different from seemingly all other
> supported platforms, which return 0 on success (and still -1 on
> failure). As such, the current check in version.c doesn't work on
> Solaris.
It seems that POSIX.1 is pretty clear on this.
    Upon successful completion, a non-negative value shall be
    returned. Otherwise, -1 shall be returned and errno set to
    indicate the error.

Erroring upon seeing a non-zero value like the preimage of your patch below *is* buggy, and the updated code looks right.

Show 18 quoted lines
> I managed to fix this with:
>
> --- git-2.56.0/version.c
> +++ git-2.56.0/version.c
> @@ -83,7 +83,7 @@ int get_uname_info(struct strbuf *buf, u
>  {
>  	struct utsname uname_info;
>  
> -	if (uname(&uname_info)) {
> +	if (uname(&uname_info) < 0) {
>  		strbuf_addf(buf, _("uname() failed with error '%s' (%d)\n"),
>  			    strerror(errno),
>  			    errno);
>
>
> which *I think* should work on other platforms as well ([2]), but
> I might be missing some where this change wouldn't work. Still, I
> wanted to at least report this.
Thanks.  Care to make it into a real patch?
Jakub Kulik· Nov 18, 2026, 16:01 UTC · re: Junio C Hamano · lore

[PATCH] version: accept positive uname(2) return values

POSIX specifies that uname(2) can return any non-negative value on success. Update the get_uname_info() check to follow this.

Signed-off-by: Jakub Kulik <jakub.kulik@oracle.com>
---
Thank you. Hope this is how it should look.
 version.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/version.c b/version.c
index 21ec7c0fbe..ca3be6d610 100644
--- a/version.c
+++ b/version.c
@@ -83,7 +83,7 @@ int get_uname_info(struct strbuf *buf, unsigned int full)
 {
 	struct utsname uname_info;
 
-	if (uname(&uname_info)) {
+	if (uname(&uname_info) < 0) {
 		strbuf_addf(buf, _("uname() failed with error '%s' (%d)\n"),
 			    strerror(errno),
 			    errno);
-- 
2.50.1
Junio C Hamano· Nov 18, 2026, 17:11 UTC · re: Jakub Kulik · lore

Re: [PATCH] version: accept positive uname(2) return values

Jakub Kulik <jakub.kulik@oracle.com> writes:
Show 6 quoted lines
> POSIX specifies that uname(2) can return any non-negative value on
> success. Update the get_uname_info() check to follow this.
>
> Signed-off-by: Jakub Kulik <jakub.kulik@oracle.com>
> ---
> Thank you. Hope this is how it should look.
Perfect.  Thanks.
Show 17 quoted lines
>
>  version.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/version.c b/version.c
> index 21ec7c0fbe..ca3be6d610 100644
> --- a/version.c
> +++ b/version.c
> @@ -83,7 +83,7 @@ int get_uname_info(struct strbuf *buf, unsigned int full)
>  {
>  	struct utsname uname_info;
>  
> -	if (uname(&uname_info)) {
> +	if (uname(&uname_info) < 0) {
>  		strbuf_addf(buf, _("uname() failed with error '%s' (%d)\n"),
>  			    strerror(errno),
>  			    errno);

← back to recent threads