git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] symbolic-ref: trivial style fix

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 15, 2013, 23:34 UTC
Message-ID
<xmqqbo2q9khe.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20131015231628.GG9464@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 7 quoted lines
>> -		     &&	dfa->nodes[node].type == CHARACTER
>> +		     && dfa->nodes[node].type == CHARACTER
>
> It took a little staring to see what changed here.  The preimage has
> a tab, probably from an autoformatter gone wild.  I don't think fixing
> it should interfere with importing new versions of compat/regex, so
> the change seems fine.

xdiff/xemit.c had the breakage of the same nature. Perhaps the commit log message should mention these two.

Previous: Jonathan NiederNext: Felipe Contreras
Message 4 of 6 in “symbolic-ref: trivial style fix”
  1. symbolic-ref: trivial style fixFelipe Contreras, Sep 21, 2013
  2. Junio C HamanoOct 15, 2013
  3. Jonathan NiederOct 15, 2013
  4. Junio C HamanoOct 15, 2013
  5. Felipe ContrerasOct 16, 2013
  6. Junio C HamanoOct 16, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.